Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kamaji deployment on eks #680

Merged
merged 10 commits into from
Feb 13, 2025
Merged

Add kamaji deployment on eks #680

merged 10 commits into from
Feb 13, 2025

Conversation

ilyesAj
Copy link
Contributor

@ilyesAj ilyesAj commented Jan 29, 2025

closes #69

@ilyesAj ilyesAj marked this pull request as draft January 29, 2025 10:11
@netlify Netlify
Copy link

netlify bot commented Jan 29, 2025 •
edited
Loading

✅ Deploy Preview for kamaji-documentation ready!

Name Link
🔨 Latest commit f42fe5f
🔍 Latest deploy log https://app.netlify.com/sites/kamaji-documentation/deploys/67ae1e7c7752a8000826189d
😎 Deploy Preview https://deploy-preview-680--kamaji-documentation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ilyesAj ilyesAj changed the title [Draft] add kamaji deployment on eks Add kamaji deployment on eks Feb 8, 2025
@ilyesAj ilyesAj marked this pull request as ready for review February 8, 2025 22:52
@ilyesAj ilyesAj requested a review from prometherion February 8, 2025 23:00
prometherion
prometherion requested changes Feb 11, 2025
View reviewed changes
Copy link
Member

@prometherion prometherion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were some typos corrected with Grammarly, besides some minor improvements and clarification on Kamaji: let me know your thoughts!

@ilyesAj
Copy link
Contributor Author

ilyesAj commented Feb 11, 2025

There were some typos corrected with Grammarly, besides some minor improvements and clarification on Kamaji: let me know your thoughts!

thank you for your review, everything is fixed now

@ilyesAj ilyesAj requested a review from prometherion February 11, 2025 19:46
prometherion
prometherion requested changes Feb 12, 2025
View reviewed changes
Copy link
Member

@prometherion prometherion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you can browse from the preview link from Netlify, the kamaji-aws-deployment.md file must be added here:

kamaji/docs/mkdocs.yml

Lines 63 to 73 in abfc65a

- 'Guides':
- guides/index.md
- guides/kamaji-azure-deployment.md
- guides/alternative-datastore.md
- guides/kamaji-gitops-flux.md
- guides/upgrade.md
- guides/datastore-migration.md
- guides/backup-and-restore.md
- guides/certs-lifecycle.md
- guides/cluster-api.md
- guides/console.md

We could place after the Azure one.

@prometherion prometherion mentioned this pull request Feb 12, 2025
Closed
@ilyesAj ilyesAj force-pushed the feat/add_eks_deployment branch from 981e806 to 1329a60 Compare February 13, 2025 16:02
@ilyesAj ilyesAj requested a review from prometherion February 13, 2025 16:04
prometherion
prometherion requested changes Feb 13, 2025
View reviewed changes
prometherion
prometherion approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@prometherion prometherion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the hard work in getting this done, and welcome as a Kamaji contributor: it's an important milestone to keep the project open and well-documented for new comers! 🚀

@prometherion prometherion merged commit c954722 into clastix:master Feb 13, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prometherion prometherion prometherion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document how to deploy Kamaji on AWS
2 participants
@ilyesAj @prometherion